Skip to content

S48-XX: Add default value of 10 for required maxInstances when creating new vpcAccessConnecton#85

Merged
JakesObrien merged 1 commit intomasterfrom
S48-update-vpcAccessConnector
Mar 24, 2026
Merged

S48-XX: Add default value of 10 for required maxInstances when creating new vpcAccessConnecton#85
JakesObrien merged 1 commit intomasterfrom
S48-update-vpcAccessConnector

Conversation

@JakesObrien
Copy link
Copy Markdown
Contributor

@JakesObrien JakesObrien commented Mar 23, 2026

Pull Request

Description

Added a default maxInstances of 10 which is required when creating a vpcAccessConnector

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Release preparation

Reviewers

@AndrewBarber @tgerulaitis @iamsambrown

Release Checklist

If this PR is preparing a release, please ensure:

  • The version in package.json has been updated following Semantic Versioning principles
    • Major version bump for breaking changes
    • Minor version bump for new features
    • Patch version bump for bug fixes
  • The CHANGELOG.md has been updated with details of the changes under the [Unreleased] section
    • Added any new features under "### Added"
    • Documented any changes under "### Changed"
    • Documented any bug fixes under "### Fixed"
    • Documented any breaking changes under "### Breaking changes"
  • All tests pass locally (npm run test)
  • Code linting passes (npm run lint)
  • The PR title clearly describes the changes

Post-Merge Automation

After merging to master, the following will happen automatically:

  • The package will be published to npm
  • A GitHub release will be created with the CHANGELOG content
  • The PR will be commented with the release information

Testing

Tested Locally by Building TF and reviewing changes

# google_vpc_access_connector.connector-10-1-1-0 will be created
+ resource "google_vpc_access_connector" "connector-10-1-1-0" {
    + connected_projects = (known after apply)
    + id                 = (known after apply)
    + ip_cidr_range      = "10.1.1.0/28"
    + machine_type       = "e2-micro"
    + max_instances      = 10
    + max_throughput     = (known after apply)
    + min_instances      = (known after apply)
    + min_throughput     = (known after apply)
    + name               = "connector-10-1-1-0"
    + network            = "static-ip-vpc"
    + project            = "oase-ecommerce-staging"
    + region             = "europe-west2"
    + self_link          = (known after apply)
    + state              = (known after apply)
}

Additional Notes

@github-actions
Copy link
Copy Markdown

🚀 Beta version published: 5.0.1-beta.pr.85.20260323162121

You can install this version with:

npm install @space48/cloud-seed@5.0.1-beta.pr.85.20260323162121

@JakesObrien JakesObrien merged commit 3dfcf70 into master Mar 24, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants