Merged
Conversation
Update Garoa Hacker Clube.
s3lph
approved these changes
Mar 5, 2025
Member
s3lph
left a comment
There was a problem hiding this comment.
Hi!
Thanks for the update. There's some minor improvements you could make to your endpoint:
- We recently released v15 of the SpaceAPI schema. Since your endpoint would already be compliant with v15, you'd only need to add a
"15"to theapi_compatibilitylist to claim support for it. - Your endpoint does not set a CORS header, which prevents it from being used in web-based clients. Fixing this is as simple as adding the header
Access-Control-Allow-Origin: *to your HTTP response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Garoa Hacker Clube.