Fix point-in-polygon problems#368
Merged
pklampros merged 4 commits intoSpaceGroupUCL:masterfrom Jul 22, 2020
Merged
Conversation
…tside the polygon region
bd3d4dc to
aaa763b
Compare
pklampros
added a commit
that referenced
this pull request
Sep 2, 2020
Fix point-in-polygon problems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues when testing points in polygons.
From my understanding the algorithm used for point-in-polygon testing is a convoluted Ray-casting algorithm whereas we start from the point of interest and move in a direction to hit the sides of the polygon. If we find even sides the point is outside, odd sides within, hence the "counter % 2 != 0" checks. The algorithm is convoluted because the ShapeMap::testPointInPoly function first checks if the point is on the border and then travels left, right, up or down depending on the side and down if the point is found within the polygon. The complexity is also dut to an underlying grid for each shapemap which helps detect shapes and identify whether the point is sitting roughly within the polygon, on its border, left, right, top or bottom, but is only accurate to each cell (the size of which has been defined arbitrarily).
The two fixes provided are: