feat: pirate empire color and label for ship_value NPC fleet benchmarks#152
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
The leaderboard
ship_valuecategory now includes pirate and empire NPC fleet benchmark entries (from gameserver#1549). The frontend needs color and display-name support for thepirateempire ID that the pirate NPC fleet uses.Technical Approach
In
page.tsx:pirate: '#cc3333'toEMPIRE_COLORSso the pirate fleet entry gets a red empire badge.case 'pirate': return 'Pirate Fleet'toempireName()so the badge shows a readable label.ship_valuecategory description to note that empire and pirate NPC fleets appear as benchmark entries.Player-Facing Release Notes