fix: unwrap v2 delta-wrapped mutation responses in the play client#154
Merged
Conversation
HTTP v2 mutations opt every request into v2 state deltas, so gameserver delivers a multi-tick travel/jump arrival over WS with the typed action response (action/poi/poi_data) nested under `details` instead of at the top level. GameProvider read `result.action` directly, which is always undefined on that shape, so the arrived/jumped check never matched and the get_system/get_poi refresh that populates poi.resources (and thus the Mine button) never fired until a manual page reload.
…vel/jump The gameserver's HTTP v2 API opts every mutation request into v2 state deltas, so ANY completed mutation response (dock, mine, craft, salvage, complete_mission, modify_order, jump, etc.) — not just deferred travel/jump arrivals — comes back with the typed handler response nested under a `details` field instead of at the top level. sendCommand()'s HTTP response path never unwrapped this, so panels reading fields directly off a mutation's resolved value were silently getting undefined: - MissionsPanel: complete_mission rewards (credits/items/skill XP/chain) never shown - CraftingPanel: job queue, optimistic job cards, and dry-run quotes all blank - SalvagePanel: salvage yield modal always blank - useAutoTravel: the in_combat abort check on jump never fired - OrdersView: listing fee notice missing after repricing an order unwrapActionResult now merges `details` back over the top level (kept as a merge, not a replace, so delta-only fields like player/ship/ location survive alongside it), and sendCommand()'s response handling applies it the same way the WS action_result path already does.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gameserver's HTTP v2 API opts every mutation request into "v2 state deltas," so a completed mutation response (dock, mine, craft, salvage, complete_mission, jump/travel arrival, etc.) comes back with the real typed response nested under a
detailsfield instead of at the top level. The/playclient'ssendCommand()and its WebSocketaction_resulthandler read fields likeresult.action/result.messagedirectly off the raw response, which silently broke once the server started delta-wrapping — most visibly as "no Mine button until refresh" after traveling to a POI, but the same issue affected several other panels that read a mutation's resolved value directly:Technical Approach
Added
unwrapActionResult()inGameProvider.tsx, which merges a response'sdetailsfield back over its top level when present (details fields win on key collision; delta-only fields likeplayer/ship/locationare preserved). Applied it at both places a mutation response is consumed — the WSaction_resulthandler andsendCommand()'s HTTP response path — so every panel that callssendCommand()gets the flat shape it expects, without touching each panel individually.Added
GameProvider.test.ts(bun:test, matching the project's existing pure-function testing convention) covering the delta-wrapped case, the already-flat passthrough case, a defensive non-objectdetailscase, and preservation of delta-only top-level fields.Verified with
pnpm lint(tsc --noEmit, clean) andpnpm build(clean production build), plus the fullbun testsuite.User-Facing Changes
Generated by Claude Code