Skip to content

add heartbeat thread#11

Merged
raffael0 merged 1 commit intomainfrom
feat/heartbeats
Apr 12, 2026
Merged

add heartbeat thread#11
raffael0 merged 1 commit intomainfrom
feat/heartbeats

Conversation

@miDeb
Copy link
Copy Markdown
Member

@miDeb miDeb commented Apr 5, 2026

  • send heartbeat requests at regular intervals to all nodes
  • register heartbeat responses

Things to be done/defined:

  • How should we handle unresponsive nodes? Should we try to detect that, or do we just note down received heartbeats as I did here?
  • Should we check if the received heartbeat value matches what we expected? What do we do if it doesn't?

- send heartbeat requests at regular intervals to all nodes
- register heartbeat responses
@miDeb
Copy link
Copy Markdown
Member Author

miDeb commented Apr 5, 2026

We could also save a bit on bus bandwidth by not sending a heartbeat_req to each node individually but just broadcast it to all nodes (of course that would mean we can't have a heartbeat counter for each node individually)

@miDeb miDeb requested a review from raffael0 April 5, 2026 22:03
Copy link
Copy Markdown
Member

@raffael0 raffael0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks ❤️

I think for now it's fine to just note down the time when we last received a heartbeat. Later on we should periodically check that and send the node state to the ECUI.

Should we check if the received heartbeat value matches what we expected? What do we do if it doesn't?

Good question. I don't think we should do anything actively if it doesn't match. Once we pass the status messages to the ECUI, we can also define some Ferroflow messages and this should be one of them.

Broadcasting messages

I don't think this will be the biggest bandwidth eater so i'd just leave it as is for now

@raffael0 raffael0 merged commit 54fe82c into main Apr 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants