Fix estimate fee#1
Merged
freddiecoleman merged 2 commits intoMay 21, 2026
Merged
Conversation
coinset's get_fee_estimate accepts only `cost` + `target_times` and rejects `spend_type`/`spend_count`. estimate_fee forwarded those, so a bare call (or one with `spend_type`) errored with "missing field `cost`" / "unknown field `spend_type`" — only an explicit `cost` ever worked. Resolve to a `cost` and send only `cost` + `target_times`: the explicit `cost` if given, else the `spend_type`'s approximate cost (rough multiples of one standard spend) or a standard spend, scaled by `spend_count`. The spend_type / spend_count hints stay and are mapped to a cost client-side (coinset's own error says "use cost instead"). Param/tool descriptions are unchanged. Also fixes the unit test, which had mocked get_fee_estimate and asserted the broken no-cost payload — so it stayed green while the real call failed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Thanks for the bug report and contribution! |
chia.net's Jan-2024 fees post puts offer-take cost at 80-150M. The previous 44M (4x) under-shoots by ~2-3x, and because coinset ranks by cost-per-fee, an under-estimated cost yields an under-estimated fee for this spend_type — the user's transaction would sit longer than the target_times they asked for. 9x (99M) sits in the middle of the published range and matches the table's "multiples of one standard spend" style. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(claude and) I found a bug in
get_fee_estimate, while I was playing around with it, looking at making this work with a local full node, and experimenting with a full rust port.Tool calls didn't seem to work except in a single scenario. As claude determined:
This pull request is meant to fix that, but you may have a better way to do it.