v1.0.0-pre4

🛠️ Fixes & Improvements

coreanim_core:

• Fix typo in set_bone_override function.

• Allow for scale override, it wasn't intentional to make that no-op argument, at least for now.

• Improve how we fetch numeric value from dedicated_server_step, fixing compatibility with MCL games at library level.

Note

This is still more or less a workaround, dedicated_server_step should itself be a number. But it seems Minetest engine doesn't care much about it, being capable of interpreting it correctly anyway, and MCL devs probably unintentionally add inline comment that is actually interpreted as a value to their game.conf. At least code is now prone to that error, and we support it.

coreanim_head:

• Use minetest.log() for warnings instead of warn() since I didn't know back then LuaJIT didn't support it (yet? ever?).

🧼️ Refactorings

coreanim_core:

• Use helper function to generate objects (tables) in set_bone_position, this is done to (hopefully) make the code easier to read by splitting some generic constructions outside of the main logic.

• Refactor how step_default's fallback value is set, instead of large if construction just use or.

• Remove some no longer necessary if block, detach_call already sets detached set_bone_override if it wasn't set before.

coreanim_compat:

• Implement unregister of the on_joinplayer callback by replacing it with no-op (empty) function, to avoid unnecessary condition checks each time it runs (possible performance benefits?). It can't be trully unregistered, at least without any risk of conflicting with the internal engine logic that loops over the registered_on_joinplayers table.

---

Full Changelog: v1.0.0-pre3...v1.0.0-pre4