fix: panic on unhandled error rather than only printing it #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, pineflash would 'handle' all errors by printing them, annoyingly eating the stack trace. This is a trivial substitution of `panic!` in place of `println!` – pineflash still prints the error message, but now with the stack trace included, assuming `RUST_BACKTRACE` is set. Related-to: Spagett1gh-57
acuteaangle
force-pushed
the
panic_on_error
branch
from
bcbf335 to
66c2b30
Compare
Owner
|
Yeah that's a good call, thank you. |
12 tasks
Merged
acuteaangle
added a commit
to acuteaangle/pineflash
that referenced
this pull request
Jan 4, 2025
This adds GitHub Actions integration to automatically build (and run tests, should they be added in the future) on Windows, MacOS, and Linux. This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83) from recurring in the future. Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
acuteaangle
added a commit
to acuteaangle/pineflash
that referenced
this pull request
Jan 4, 2025
This adds GitHub Actions integration to automatically build (and run tests, should they be added in the future) on Windows, MacOS, and Linux. This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83) from recurring in the future. Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
acuteaangle
added a commit
to acuteaangle/pineflash
that referenced
this pull request
Mar 23, 2025
This adds GitHub Actions integration to automatically build (and run tests, should they be added in the future) on Windows, MacOS, and Linux. This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83) from recurring in the future. Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, pineflash would 'handle' all errors by printing them, annoyingly eating the stack trace. This is a trivial substitution of
panic!in place ofprintln!– pineflash still prints the error message, but now with the stack trace included, assumingRUST_BACKTRACEis set.Related-to: gh-57