Skip to content

[MMA-2184] Update cPanel addon to work with PHP 7.2#104

Merged
donici merged 1 commit intomasterfrom
mma-2184
Aug 19, 2019
Merged

[MMA-2184] Update cPanel addon to work with PHP 7.2#104
donici merged 1 commit intomasterfrom
mma-2184

Conversation

@emiliangrecu
Copy link
Copy Markdown
Contributor

No description provided.

}

if (count($domains) > 0) {
$countDomains = count($domains);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed you checked is_array(x) or is_countable(x) in all other places, except here. I don't know if it is an issue, but just letting you know.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because in this case $domains is an array built locally right before that count:

        // Retrieve all domains
        $collectionDomains = $this->getCollectionDomains();
        $domains           = array();
        foreach ($collectionDomains as $collectionDomain) {
            $domains[] = $collectionDomain['name'];
        }

        $countDomains = count($domains);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for the clarification.

@tonyandrewmeyer tonyandrewmeyer requested review from a team and removed request for tonyandrewmeyer August 14, 2019 22:02
@ghost ghost requested review from ciprian-macovei and smeadaandrei and removed request for a team August 14, 2019 22:02
@donici donici merged commit 75cc25c into master Aug 19, 2019
@LaurentiuTeodorescu LaurentiuTeodorescu deleted the mma-2184 branch May 23, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants