When sending data to the API, data string should be converted to byte array only once #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for catching that. |
yepher
added a commit
that referenced
this pull request
Mar 10, 2016
When sending data to the API, data string should be converted to byte array only once
Contributor
|
This has been released: And Nexus here: (If you don't see it in Maven repo immediately check back as the Maven cache takes some time to update) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
RestConnection.sendData(..), theString dataparameter is converted to a byte array twice: once to get the number of bytes, then again to actually send it. With my change, it's converted to a byte array only once.