Removed defaults for engagement tracking so that template settings could... #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld be applied when using the SDK
Contributor
|
Any reason not to merge this @nornholdj ? Do we need any additional tests here? |
Contributor
Author
|
Sorry @richleland, I didn't realize that this was still open. Yes I believe this can be merged. Its to align with a change we made to the node sdk a while ago. It was a bug where the sdk made it impossible to rely on the engagement settings on a template and would cause them to always be set on the transmission level. |
bdeanindy
added a commit
that referenced
this pull request
Aug 3, 2015
Removed defaults for engagement tracking so that template settings could...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... be applied when using the SDK