Skip to content

Conversation

@beardyman
Copy link
Contributor

Closes #19

@jasonrhodes
Copy link
Contributor

Not sure if I totally understand how this is supposed to work, but I think it's supposed to auto-generate that example-config file for people after they install this package, but per the composer website:

Note: Only scripts defined in the root package's composer.json are executed. If a dependency of the root package specifies its own scripts, Composer does not execute those additional scripts.

If it's called "example-config" do we really need to .gitignore it?

@jasonrhodes
Copy link
Contributor

Ok so I've got xdebug installed and I'm running composer test, it runs tests and generates code coverage but I get the following error output:

Warning: date(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected the timezone 'UTC' for now, but please set date.timezone to select your timezone. in /Users/jrhodes/php-project/php-sparkpost/vendor/phpunit/php-code-coverage/src/CodeCoverage/Report/HTML.php on line 75

Call Stack:
    0.0002     247568   1. {main}() /Users/jrhodes/php-project/php-sparkpost/vendor/phpunit/phpunit/phpunit:0
    0.0846     593720   2. PHPUnit_TextUI_Command::main() /Users/jrhodes/php-project/php-sparkpost/vendor/phpunit/phpunit/phpunit:56
    0.0846     594344   3. PHPUnit_TextUI_Command->run() /Users/jrhodes/php-project/php-sparkpost/vendor/phpunit/phpunit/src/TextUI/Command.php:138
    0.2867    2639568   4. PHPUnit_TextUI_TestRunner->doRun() /Users/jrhodes/php-project/php-sparkpost/vendor/phpunit/phpunit/src/TextUI/Command.php:186
    6.1857   16081344   5. PHP_CodeCoverage_Report_HTML->process() /Users/jrhodes/php-project/php-sparkpost/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:471
   10.6320   22806344   6. date() /Users/jrhodes/php-project/php-sparkpost/vendor/phpunit/php-code-coverage/src/CodeCoverage/Report/HTML.php:75

 done

@beardyman
Copy link
Contributor Author

Its because you don't have a default timezone set in your php.ini file.

Set: date.timezone = America/New_York in php.ini.

That is on line 930 in mine but it should be close to that in your ini file.

@jasonrhodes
Copy link
Contributor

Nice. OK this LGTM.

jasonrhodes added a commit that referenced this pull request Oct 2, 2015
@jasonrhodes jasonrhodes merged commit 7b12923 into master Oct 2, 2015
@jasonrhodes jasonrhodes deleted the example-config branch October 2, 2015 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants