Skip to content

Conversation

@arturfsousa
Copy link
Contributor

Adding an encode('utf-8') in the end of the json generated string may help.

@richleland
Copy link
Contributor

@arturfelipe thanks for submitting! Can you get those tests passing?

@rajumsys
Copy link
Contributor

rajumsys commented Mar 2, 2017

@arturfelipe Thanks for the PR. As @richleland asked to fix the broken test, I wanted to help by fixing the test but seems I can't the re-produce this problem in the master branch. I tried the non-ascii chars you've used in your new tests to send a transmission but i see the transmissions are delivered correctly.

substitution_data =  {'name': '漢字'}

response = sp.transmission.send(recipients=['RETRACTED'],html='<p>Hello there</p>{{name}}',from_email="RETRACTED", subject="hi {{name}}", substitution_data=substitution_data)

Part of Gmail's show original

Content-Type: text/html; charset="UTF-8"
Subject: hi 漢字
To: RETRACTED
Date: Thu, 02 Mar 2017 19:45:22 +0000
MIME-Version: 1.0
From: RETRACTED

<p>Hello there</p>=E6=BC=A2=E5=AD=97

So can you please help me understand the problem you're trying to solve?

@richleland
Copy link
Contributor

I'm going to go ahead and close this out, but if the issue continues to exist, don't hesitate to re-open.

@richleland richleland closed this May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants