Skip to content

Removed .msi installer remains #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2022
Merged

Removed .msi installer remains #66

merged 1 commit into from
Sep 22, 2022

Conversation

bounav
Copy link
Collaborator

@bounav bounav commented Sep 22, 2022 •
edited
Loading

  • It looks like once upon a time, the project was distributed with by means of .msi installers.
  • None of it was still in use so I removed the relevant bits.

@bounav
Removed installer remains
ead1e27 
- It looks like once upon a time spark was distributed with an msi installer.
- None of this was used (probably since the project is on nuget)
RobertTheGrey
RobertTheGrey approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@RobertTheGrey RobertTheGrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the MSI was a long time ago, before Nuget was a thing. No longer required

@bounav bounav merged commit 3eaef13 into master Sep 22, 2022
@bounav bounav deleted the removed-installers branch September 22, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobertTheGrey RobertTheGrey RobertTheGrey approved these changes

Assignees

@RobertTheGrey RobertTheGrey

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bounav @RobertTheGrey