Spark no longer depends on System.Web #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SparkViewEngine no longer depends on System.Web.Hosting - Removed "ViewFolderType.cs" enum - Can no longer configure "ViewFolder" using the view folder type, you have to either use the default or configure it one using as if it was a custom one - New Spark.Web project to contain the bits that depend on System.Web (e.g. VirtualPathProviderViewFolder)
- No longer using deprecated nunit Is.Not.StringContaining("")
- Tweaked getters and setter syntax on configuration Element classes
- Moved Cache and SparkViewBase related bits to Spark.Web
- This code is not going to be relevant for .net core stuff (JSON configuration would be used instead) - Breaking change the section type attribute will have to change to "Spark.Configuration.SparkSectionHandler, Spark.Web"
RobertTheGrey
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark.Webto contain bits of code that depend onSystem.WebSpark.Web.Mvc...,Castle.Monorail...andXparkproject now have a reference toSpark.Webinstead ofSparkCacheandSparkVewBase(and releted classes) toSpark.WebSparktoSpark.Webassembly (see breaking change section below). Not stricly necessary but it makes sense IMHO to move that out of Spark since nove of configuration element will be relevant to future .net core bit (since it will use code or JSON configuration).Breaking Change
If you configure spark from your App.config (or Web.config) file you will need to adjust the assembly part of the fully qualified name for the
<section type="..." />tag.Becomes
NB: We'll have to update the relevant wiki page when this is released.