Skip to content

chore: export setup complete#2

Merged
jamesblasco merged 1 commit intosparkli-mainfrom
chore/export_setup_complete
Oct 8, 2025
Merged

chore: export setup complete#2
jamesblasco merged 1 commit intosparkli-mainfrom
chore/export_setup_complete

Conversation

@jamesblasco
Copy link
Copy Markdown
Collaborator

@jamesblasco jamesblasco commented Oct 8, 2025

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Summary by CodeRabbit

  • New Features
    • Exposed a new signal/event in the Live API indicating when the live server setup has completed. This allows apps to programmatically await readiness, simplify initialization flows, and provide clearer user feedback during connection/setup phases. Improves reliability of first-run experiences and reduces race conditions during startup. No changes are required for existing integrations.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 8, 2025

Walkthrough

Added LiveServerSetupComplete to the public exports from src/live_api.dart via firebase_ai.dart. No other files or APIs changed.

Changes

Cohort / File(s) Summary of Changes
Public export update
packages/firebase_ai/firebase_ai/lib/firebase_ai.dart
Updated export list to include LiveServerSetupComplete from src/live_api.dart.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my ears at a symbol new,
Hopped into exports, crisp and true.
A name unveiled, no code to fight—
Just doors unlocked to broader light.
Thump-thump! I stamp in tidy glee,
One more carrot in the API tree. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive The title “chore: export setup complete” vaguely refers to exporting something related to setup completion but does not clearly identify the specific API change, making it difficult for readers to immediately grasp that the PR adds the LiveServerSetupComplete symbol to the public exports. Consider renaming the title to explicitly reference the exported symbol and context, for example “chore: export LiveServerSetupComplete in firebase_ai.dart” to clearly communicate the primary change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/export_setup_complete

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9b7ecf1 and 987591e.

📒 Files selected for processing (1)
  • packages/firebase_ai/firebase_ai/lib/firebase_ai.dart (1 hunks)
🔇 Additional comments (1)
packages/firebase_ai/firebase_ai/lib/firebase_ai.dart (1)

99-99: Approve export of LiveServerSetupComplete.

Defined in src/live_api.dart and covered by existing tests.


Comment @coderabbitai help to get the list of available commands and usage tips.

@jamesblasco jamesblasco merged commit b895ae2 into sparkli-main Oct 8, 2025
6 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jan 14, 2026
@coderabbitai coderabbitai Bot mentioned this pull request May 6, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants