[ONEMKL_SYCL] Rearrange MKL backend and add logging#22
Merged
Conversation
spencerpatty
commented
Feb 21, 2025
…work with nnz as int64_t * [Examples] Add comments to simple examples * [LOG][ONEMKL_SYCL] Add log system to repository and shift mkl->onemkl_sycl with some separations out into individual files for implementations
fd31457 to
cecb695
Compare
BenBrock
requested changes
Feb 24, 2025
Collaborator
There was a problem hiding this comment.
Looks mostly good! As you mentioned over chat, the IESPBLAS stuff needs to be removed from this PR. There's one necessary change and two requested changes:
- The CI needs to be updated to build MKL using the new CMake flag. (Note that although all the CI jobs are passing, it's not actually building with MKL at the moment.)
And nice-to-haves:
- I'd prefer
Tinstead ofDATA_TYPEin examples. If you strongly desire to have a multi-character type alias, please usevalue_typeto be consistent with the rest of the codebase. (Andindex_typeandoffset_typefor indices and offsets.) - I'd also prefer to stick to
fmtin the examples instead of using iostream, given that we're already including it. Should be an easy change.
BenBrock
reviewed
Feb 24, 2025
Contributor
Author
|
@BenBrock I have made all suggested changes, and it is ready for check again. |
BenBrock
approved these changes
Feb 25, 2025
Collaborator
BenBrock
left a comment
There was a problem hiding this comment.
Looks good. I just moved log.hpp from backend to detail and added a missing header that was preventing compilation on OS X.
We eventually need to go back to log.hpp and prevent it from putting anything in the global namespace, as that's a no-no for C++. Fine for now though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Testing:
Builds locally with Intel oneAPI compiler and oneMKL from oneAPI 2025.0 release.