Added EWiseAdd tests for COO matrix#15
Merged
gsvgit merged 11 commits intoSparseLinearAlgebra:devfrom Mar 10, 2021
Merged
Conversation
dpanfilyonok
changed the title
dpanfilyonok
commented
Feb 28, 2021
| EWiseAdd.tests | ||
| ] | ||
|
|
||
| // sequenced test? |
Collaborator
Author
There was a problem hiding this comment.
Are these tests really sequenced when running dotnet test?
artemgl
reviewed
Feb 28, 2021
| "There should be no difference between expected and received values" | ||
| |> Expect.all difference isZero | ||
|
|
||
| let correctnessOnBool (case: OperationCase) (matrixA: bool[,], matrixB: bool[,]) = |
Collaborator
There was a problem hiding this comment.
Why it can't be generalized? It seems to be particular case of correctnessOnNumbers
| ||> Seq.map2 diff | ||
|
|
||
| "There should be no difference between expected and received values" | ||
| |> Expect.all difference isZero |
Collaborator
There was a problem hiding this comment.
Must indices (rows and columns) be checked as well?
Collaborator
|
@gsvgit tests must be working fine. Actual version of addition works a little weird as it turned out. I have already corrected it locally. It will be very convenient for me if we merge this request as it contains a lot of changes. I could check my last version and open pull request with passing tests. |
Member
|
@artemgl well. Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Need to be added in the future: