Skip to content

RFC#17

Closed
dpanfilyonok wants to merge 17 commits intoSparseLinearAlgebra:devfrom
dpanfilyonok:classes-reorganization
Closed

RFC#17
dpanfilyonok wants to merge 17 commits intoSparseLinearAlgebra:devfrom
dpanfilyonok:classes-reorganization

Conversation

@dpanfilyonok
Copy link
Copy Markdown
Collaborator

Proposed Changes

  • Added workflow builder for graphblas. Used for dependency injection.
  • Added more fair algebraic structures
  • Added MonoidicType, which trying to solve explicit zeroes behavior problem
  • Objects and methods have been separated
  • Added random sparsity to matrix generation and opencl context as test case

Copy link
Copy Markdown
Member

@gsvgit gsvgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!


// Должны принимать либо BinaryOp, либо {|BinaryOp; BinaryOp|} с соответствующей семантикой

// ждём тайпклассов чтобы можно было вызывать synchronize для всех объектов,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)


and BitmapVector<'a> =
{
Bitmap: bool[]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use BitArray instead?

<ItemGroup>
<Compile Include="AssemblyInfo.fs" />
<Compile Include="Common.fs" />
<Compile Include="OperationsTests\MxvTests.fs" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OS-specific path?

@dpanfilyonok dpanfilyonok mentioned this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants