Skip to content

CSR.eWiseAdd#32

Merged
gsvgit merged 2 commits intoSparseLinearAlgebra:net5from
kirillgarbar:net5
Nov 23, 2021
Merged

CSR.eWiseAdd#32
gsvgit merged 2 commits intoSparseLinearAlgebra:net5from
kirillgarbar:net5

Conversation

@kirillgarbar
Copy link
Copy Markdown
Contributor

Previously incorrectly generalized function is set back, test for CSR addition are passing.

<| (fun size -> makeTest context (PairOfSparseMatricesOfEqualSize.ByteType()) size COO (+) <@ (+) @> 0uy)

testProperty "Correctness test on random int arrays CSR"
<| (fun size -> makeTest context (PairOfSparseMatricesOfEqualSize.IntType()) size CSR (+) <@ (+) @> 0)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why CSR tests are in COOMatrixEwiseAddTests.fs ?

<| (fun size -> makeTest context (PairOfSparseMatricesOfEqualSize.IntType()) size COO (+) <@ (+) @> 0)

testProperty "Correctness test on random bool arrays"
testProperty "Correctness test on random bool arrays COO"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrays or matrices?

let kernelCNPRS =
clContext.CreateClKernel calcNnzPerRowSparse

let kernelENPR = clContext.CreateClKernel expandNnzPerRow
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not use such strange abbreviations.

@gsvgit gsvgit merged commit 1805e3a into SparseLinearAlgebra:net5 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants