Vector#48
Merged
gsvgit merged 78 commits intoSparseLinearAlgebra:net5from Nov 19, 2022
IgorErin:vector
Merged
Conversation
kirillgarbar
suggested changes
Nov 13, 2022
| |> Array.sortBy fst | ||
| |> Array.unzip | ||
|
|
||
| let resultLenght = (Array.max indices) + 1 |
Contributor
There was a problem hiding this comment.
I think for dense vector this is incorrect. In dense case ofList operation should create vector with zeroes and assign non-zero values by given indices. This means that number of indices can be lesser than size of the array and ofList should take vector size as a parameter
kirillgarbar
suggested changes
Nov 18, 2022
|
|
||
| let result = | ||
| clContext.CreateClArray( | ||
| 1, |
Contributor
There was a problem hiding this comment.
In this case ClCell can be used instead of ClArray
| | _, None -> left | ||
| | _ -> right @> | ||
|
|
||
| let maskOp<'a, 'b when 'a: struct and 'b: struct> = |
Contributor
There was a problem hiding this comment.
Complemented mask operation can also be added
kirillgarbar
approved these changes
Nov 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of changes
What types of changes does your code introduce to GraphBLAS-sharp?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.