hash_pair fix#227
Merged
gsvgit merged 7 commits intoSparseLinearAlgebra:mainfrom Feb 14, 2025
Merged
Conversation
gsvgit
approved these changes
Feb 12, 2025
CI: update macos version to 14
gsvgit
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: hash_pair fix
about: hashing algorithm
title: "[hash_pair fix]"
labels: enhancement
assignees: EgorOrachyov, gsvgit
Short description
improve hashing algorithm using advice from https://stackoverflow.com/questions/2590677/how-do-i-combine-hash-values-in-c0x
List of changes
src/util/hash_pairType of changes
Testing strategy
Tests from run_tests.py
Background
https://stackoverflow.com/questions/2590677/how-do-i-combine-hash-values-in-c0x
Addition context
I've never programming on C++ before