Merged
Conversation
Roy-wonji
approved these changes
Oct 17, 2025
| struct MovieSearchFeature { | ||
| @ObservableState | ||
| struct State: Equatable { | ||
| var nowPlayingMovies: [Movie] = [] |
Contributor
Author
There was a problem hiding this comment.
하나로 합치는게 어떻게 하는걸 말씀하시는거에요??
Peter1119
approved these changes
Oct 17, 2025
Contributor
Peter1119
left a comment
Peter1119
left a comment
There was a problem hiding this comment.
이전 코드리뷰가 함께 있는데 이럴경우에는 앞선 브랜치를 main에 머지하고
search 브랜치에 당기면 중복 부분이 사라집니다 ~!
고생하셨습니다 ~!
Comment on lines
+49
to
+59
| var aggregatedMovies: [Movie] { | ||
| let combined = nowPlayingMovies + upcomingMovies + popularMovies | ||
| var unique: [Movie] = [] | ||
| var seenIDs = Set<Int>() | ||
|
|
||
| for movie in combined where seenIDs.insert(movie.id).inserted { | ||
| unique.append(movie) | ||
| } | ||
|
|
||
| return unique | ||
| } |
Contributor
There was a problem hiding this comment.
어떤 동작인지 잘 모르겠어요
주석을 달아주시면 좋을 것 같습니다 ~!
Contributor
Author
There was a problem hiding this comment.
영화 목록들이 배열 여러개로 있어서 하나로 합친 로직입니다! 복잡한 것 같아서 간단하게 수정했습니당
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 작업 내용
Checklist