Build review, evaluation, and report workflows#10
Open
Spbd1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
engine/argument_risk_engine/review/models.pyand append-only JSONL storage + helpers inengine/argument_risk_engine/review/store.py, persisting todata/review/review_store.jsonland including a legacy-feedback adapter.GET /review/items,POST /review/items,GET /review/summary, and preserved the legacyPOST /review/feedbackadapter inbackend/app/services/review_service.pyandbackend/app/api/routes_review.py.engine/argument_risk_engine/evaluation/metrics.pyandengine/argument_risk_engine/evaluation/runner.pyto compute label precision/recall/F1, false-positive rate, evidence-span exact/partial match, human review rate, over-classification rate, and no-finding rate, and to collect false-positive/false-negative/evidence-span-miss error lists and a non-scientificdisclaimer.POST /evaluation/run,GET /evaluation/summary, andGET /evaluation/errorswith result persistence underdata/evaluationand a small JSONL mini-benchmarkdata/benchmarks/mini_eval_set.jsonl.engine/argument_risk_engine/reports/{json_export,markdown,html}.py, plus report service with local persistence/indexing and API endpointsPOST /reports/from-analysis,GET /reports,GET /reports/{report_id}, andGET /reports/{report_id}/downloadinbackend/app/services/report_service.pyandbackend/app/api/routes_reports.py./apiprefixes and added a CLI wrapperscripts/run_evaluation.pyto run the mini benchmark from the command line.tests/test_evaluation.py,tests/test_review_reports_api.py) to cover metrics, runner output, review persistence, report generation, and downloads.Testing
python scripts/run_evaluation.pywhich executed the runner and printed metrics and the disclaimer (smoke run succeeded).python -m pytest -qwhich passed (42 passed, 4 warnings).tests/test_evaluation.pyandtests/test_review_reports_api.pywhich passed (4 passed, 1 warning).python -m ruff check ...as part of CI-style linting and fixed reported issues so lint check passed locally.Codex Task