Fix audit release blockers — remove custom build backend and local shims, lock analysis to deterministic baseline#13
Open
Spbd1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
uvicornCLI maps to the real dependency and that runninguvicorn backend.app.main:app --reloadworks with a standard environment./apiprefixes.Description
pyproject.tomlbuild-system to userequires = ["setuptools>=68", "wheel"]andbuild-backend = "setuptools.build_meta"and removedbuild_backend.pyso package discovery uses normal setuptools behavior.uvicorn/,fastapi/andpydantic/stubs) so runtime imports resolve to installed dependencies instead of repository shims.engine/argument_risk_engine/analyzer.pyto forcemode = "deterministic_baseline"andmodel_provider_id = "deterministic_baseline", and added a clear warning when callers request non-deterministic/LLM modes._has_unsupported_universal_claiminengine/argument_risk_engine/classification/deterministic.pythat avoids matching trigger words in bounded, literal, quoted, or clearly sourced statements.data/taxonomy/packs/starter-pack.yamland aligned the in-codedefault_taxonomy_pack()inengine/argument_risk_engine/taxonomy/models.pywithnegative_examples,minimum_evidence_requirement, andcommon_false_positivesfor active entries.frontend/index.html,frontend/package.jsonscripts/deps, andfrontend/src/api/client.tsto use same-origin/apibase; and changedbackend/app/main.pyto add/api/healthand mountfrontend/distviaStaticFileswhen present.Testing
python -m compileall backend engine tests— succeeded (byte-compilation passed acrossbackend,engine, andtests).pip install -e .[dev]— could not complete in this environment because the runner could not fetch build/install dependencies from upstream (setuptools/network 403), so editable install was not verified here.pytest— could not complete end-to-end because realpydantic/fastapi/uvicornwere not available in the test environment after removal of local shims (dependency install blocked); test collection failed due to missing packages.uvicorn backend.app.main:app --reload --port 8002and subsequentcurlchecks — could not run becauseuvicornwas not installed in this environment after dependency installation failed.cd frontend && npm installandcd frontend && npm run build— could not complete because this environment cannot fetch npm packages (403 Forbidden) so Vite build verification did not run.If CI or a developer workstation has network access, the expected verification steps are:
pip install -e .[dev],python -m compileall backend engine tests,pytest,uvicorn backend.app.main:app --reload --port 8002and thencurl -fsS http://127.0.0.1:8002/healthandcurl -fsS http://127.0.0.1:8002/taxonomy-workbench/quality-report, andcd frontend && npm install && npm run build.Codex Task