feat(Scheduled Analysis): add scheduled analysis to the list of user-updatable parameters BED-7186

[sirisjo]

Description

Updates the list of parameters that are user-updatable to include the scheduled analysis parameter.

Motivation and Context

Resolves BED-7186

This is part of the Scheduled Analysis epic. We want scheduled analysis to be user-updatable via the API, instead of users having to go through TAMs or modify the DB directly to edit this param.

Also fixed some slog lint warnings in the parameters file.

How Has This Been Tested?

Tested locally, received 200 response.

Screenshots (optional):

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist:

• I have met the contributing prerequisites
  • Assigned myself to this PR
  • Added the appropriate labels
  • Associated an issue: Issues and Pull Requests README #672
  • Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing
• I have ensured that related documentation is up-to-date
  • Open API docs
  • Code comments (GoDocs / JSDocs)
• I have followed proper test practices
  • Added/updated tests to cover my changes
  • All new and existing tests passed

Summary by CodeRabbit

• New Features

  • Added a new "Scheduled Analysis" configuration parameter that can now be managed.

• Improvements

  • Converted many configuration warnings to structured logs with clearer fields for easier diagnosis and troubleshooting.

• Bug Fixes

  • Corrected a log message typo ("password expiration") for clearer messaging.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds a new public ParameterKey ScheduledAnalysis ("analysis.scheduled"), marks it valid and removes it from the protected set, and replaces many fmt-based warnings with structured slog warnings (including sanitized keys and error fields); also fixes a log typo.

Changes

Cohort / File(s)	Summary
Parameter key & validation cmd/api/src/model/appcfg/parameter.go	Added ScheduledAnalysis ("analysis.scheduled"). Updated IsValidKey to include it and removed it from IsProtectedKey so it is no longer protected.
Logging refactor (structured warnings) cmd/api/src/model/appcfg/parameter.go	Replaced fmt-based warnings with structured slog warnings across parameter retrieval/validation functions; added structured fields (e.g., invalid_configuration, parameter_key), sanitized parameter keys in logs, and fixed a typo ("password expiratio" → "password expiration").

Sequence Diagram(s)

(omitted — changes are localized and do not introduce a multi-component sequential flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• Useinovski
• urangel

Poem

🐰 A little key hopped into place,
Logs grew tidy, with clearer grace.
Scheduled checks now join the fray,
Warnings whisper the proper way.
A rabbit twitches — code's in place! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main change: adding scheduled analysis to user-updatable parameters, with a reference to the ticket BED-7186.
Description check	✅ Passed	The description covers key sections including Description, Motivation/Context, How Has This Been Tested, and Types of Changes, with a completed checklist.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mistahj67]

Thanks for improving the logs here! I actually think we can go a step further if you don't mind, the slog string keys are helpful to hinge filters on, what do you think about making all of these the same something like invalid_configuration and the value remains the error, and then adding another slog.String("parameter_key", ::value_is_the_key::) that way one can query logs for all or specific config loading issues?

[sirisjo]

Can do!

[mistahj67]

Code LGTM, tested locally as well 🚀