fix: ignore not found errors for primary kinds BED-8155#2718
Merged
mistahj67 merged 1 commit intostage/v9.1.0from Apr 29, 2026
Merged
fix: ignore not found errors for primary kinds BED-8155#2718mistahj67 merged 1 commit intostage/v9.1.0from
mistahj67 merged 1 commit intostage/v9.1.0from
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
kpowderly
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail
Motivation and Context
As of today custom-node-kinds table is not backed by kinds, meaning records exist that may not have a kind record in the kind table. A helper function, PrimaryKinds, serves to determine the "representative" kind of a node. It was discovered that custom nodes were not included in the primary kinds function and an effort was made to add it.
Because custom nodes kinds is not kind backed, a quick filter was applied, but that filter fails 404 if not all kinds supplied are found. This bubbled up across the endpoints as primarykind function is utilized across a number of vital systems, analysis, graph search, attack-paths, etc. A quick fix was to ignore the 404 db error
Resolves BED-8155
Why is this change required? What problem does it solve?
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Screenshots (optional):
Types of changes
Checklist: