Skip to content

fix: ignore not found errors for primary kinds BED-8155#2718

Merged
mistahj67 merged 1 commit intostage/v9.1.0from
BED-8155
Apr 29, 2026
Merged

fix: ignore not found errors for primary kinds BED-8155#2718
mistahj67 merged 1 commit intostage/v9.1.0from
BED-8155

Conversation

@mistahj67
Copy link
Copy Markdown
Contributor

@mistahj67 mistahj67 commented Apr 29, 2026

Description

  • Handle not found error during primary kinds resolution

Describe your changes in detail

Motivation and Context

As of today custom-node-kinds table is not backed by kinds, meaning records exist that may not have a kind record in the kind table. A helper function, PrimaryKinds, serves to determine the "representative" kind of a node. It was discovered that custom nodes were not included in the primary kinds function and an effort was made to add it.

Because custom nodes kinds is not kind backed, a quick filter was applied, but that filter fails 404 if not all kinds supplied are found. This bubbled up across the endpoints as primarykind function is utilized across a number of vital systems, analysis, graph search, attack-paths, etc. A quick fix was to ignore the 404 db error

Resolves BED-8155

Why is this change required? What problem does it solve?

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@mistahj67 mistahj67 self-assigned this Apr 29, 2026
@mistahj67 mistahj67 added the api A pull request containing changes affecting the API code. label Apr 29, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 3dfe3074-fe3c-4df7-8603-bd95d9df94e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BED-8155

Comment @coderabbitai help to get the list of available commands and usage tips.

@mistahj67 mistahj67 requested a review from urangel April 29, 2026 15:03
@mistahj67 mistahj67 changed the title fix: ignore not found errors for primary kinds fix: ignore not found errors for primary kinds BED-8155 Apr 29, 2026
@mistahj67 mistahj67 merged commit fee7797 into stage/v9.1.0 Apr 29, 2026
13 checks passed
@mistahj67 mistahj67 deleted the BED-8155 branch April 29, 2026 15:16
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api A pull request containing changes affecting the API code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants