Skip to content

chore: Replace typography component round 2: BED-7561#2740

Merged
jvacca-specterops merged 3 commits into
mainfrom
BED-7561-replace-typography-rnd2
May 6, 2026
Merged

chore: Replace typography component round 2: BED-7561#2740
jvacca-specterops merged 3 commits into
mainfrom
BED-7561-replace-typography-rnd2

Conversation

@jvacca-specterops
Copy link
Copy Markdown
Contributor

@jvacca-specterops jvacca-specterops commented May 5, 2026

Description

Describe your changes in detail

Converting MUI Typography components to our new DoodleUI Typography component. I missed a few in the first round which are being addressed here.

Motivation and Context

Resolves BED-7561

Why is this change required? What problem does it solve?

Eliminates MUI Typography component from the code base in favor of our own custom DoodleUI component.

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

  • Tested visually in browser
  • All existing unit tests are passing

Screenshots (optional):

Screenshots in ticket

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Database Migrations

Checklist:

Summary by CodeRabbit

Release Notes

  • Refactor

    • Updated component import sources for consistent UI styling across help text and edge information displays.
  • Style

    • Typography styling adjustments for improved visual consistency.
  • Tests

    • Updated test assertions for standardized text formatting.

@jvacca-specterops jvacca-specterops self-assigned this May 5, 2026
@jvacca-specterops jvacca-specterops added the user interface A pull request containing changes affecting the UI code. label May 5, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 5b335bbc-8d6d-4682-87d5-5cb26aafbc7a

📥 Commits

Reviewing files that changed from the base of the PR and between c047b0c and c580311.

📒 Files selected for processing (5)
  • packages/javascript/bh-shared-ui/src/components/HelpTexts/ForceChangePassword/Opsec.tsx
  • packages/javascript/bh-shared-ui/src/components/HelpTexts/WriteDacl/Opsec.tsx
  • packages/javascript/bh-shared-ui/src/components/HelpTexts/WriteDacl/WindowsAbuse.tsx
  • packages/javascript/bh-shared-ui/src/views/Explore/EdgeInfo/EdgeInfoContent.test.tsx
  • packages/javascript/bh-shared-ui/src/views/Explore/EdgeInfo/EdgeInfoContent.tsx

📝 Walkthrough

Walkthrough

Multiple components in the shared UI library have their Typography imports migrated from Material-UI to doodle-ui, and typographic apostrophes are replaced with ASCII apostrophes in text content and test assertions.

Changes

Typography Import Migration and Text Normalization

Layer / File(s) Summary
Import Updates
packages/javascript/bh-shared-ui/src/components/HelpTexts/ForceChangePassword/Opsec.tsx, packages/javascript/bh-shared-ui/src/components/HelpTexts/WriteDacl/Opsec.tsx, packages/javascript/bh-shared-ui/src/components/HelpTexts/WriteDacl/WindowsAbuse.tsx, packages/javascript/bh-shared-ui/src/views/Explore/EdgeInfo/EdgeInfoContent.tsx
Typography import moved from @mui/material to doodle-ui across four files. In WindowsAbuse.tsx, imports are split so Link remains from @mui/material.
Content and Rendering Adjustments
packages/javascript/bh-shared-ui/src/views/Explore/EdgeInfo/EdgeInfoContent.tsx
Typographic apostrophe in hidden-edge disclosure message changed to ASCII apostrophe. Edge name rendering switched from Typography-wrapped to plain <strong> element in non-hidden path.
Test Assertions
packages/javascript/bh-shared-ui/src/views/Explore/EdgeInfo/EdgeInfoContent.test.tsx
Hidden-edge test expectation updated to use ASCII apostrophe to match component output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: replacing MUI Typography components with DoodleUI, round 2, with the associated ticket BED-7561.
Description check ✅ Passed The description fully addresses all required template sections: detailed change description, motivation/context with ticket number, testing methodology, change type selection, and completed checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BED-7561-replace-typography-rnd2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jvacca-specterops jvacca-specterops marked this pull request as ready for review May 6, 2026 15:51
@jvacca-specterops jvacca-specterops merged commit ec00004 into main May 6, 2026
13 checks passed
@jvacca-specterops jvacca-specterops deleted the BED-7561-replace-typography-rnd2 branch May 6, 2026 16:22
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

user interface A pull request containing changes affecting the UI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants