Conversation
urangel
force-pushed
the
remote-content-img-src-fix
branch
from
e49598e to
4906eb2
Compare
… for url in vite config
zinic
approved these changes
Aug 9, 2023
Contributor
zinic
left a comment
zinic
left a comment
There was a problem hiding this comment.
Most recent changes look good to me. This aligns with effort in the downstream repo as well.
elikmiller
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change updates the base property in the vite.config to include the env var for base url if it is included.
Motivation and Context
URL resolution was not working correctly in some instances for RemoteContent and this change makes this more consistent with expected behavior.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: