fix(dawgrun): select or init default graph on db connect#78
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe ChangesDefault graph initialization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tools/dawgrun/pkg/commands/db.go (1)
70-70:⚠️ Potential issue | 🟠 Major | ⚡ Quick winReset all flag variables for consistency.
Only
driverOverrideis reset before parsing flags, butdefaultGraphNameandinitGraphOnFailare not. This creates an inconsistent pattern and reduces defensive safety in caseClearFlagsFnis not invoked.🔧 Proposed fix to reset all flag variables
Fn: func(ctx *CommandContext, fields []string) error { driverOverride = "" + defaultGraphName = "default" + initGraphOnFail = false if err := flagSet.Parse(fields); err != nil {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tools/dawgrun/pkg/commands/db.go` at line 70, Reset the remaining flag state variables alongside driverOverride before flag parsing: ensure defaultGraphName and initGraphOnFail are explicitly reset (e.g., set to "" and false respectively) in the same initialization block where driverOverride is set so flag parsing starts from a known, consistent state; update the same function that currently sets driverOverride (and document/align with ClearFlagsFn if present) to include these resets referencing the variables defaultGraphName and initGraphOnFail.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tools/dawgrun/pkg/commands/db.go`:
- Around line 64-67: The ClearFlagsFn currently resets driverOverride and
defaultGraphName but forgets to reset the initGraphOnFail boolean, causing its
value to persist across REPL commands; update the ClearFlagsFn to also
reinitialize initGraphOnFail (set it back to its default, e.g., false) alongside
resetting driverOverride and defaultGraphName so every command invocation starts
with the expected flag state.
---
Outside diff comments:
In `@tools/dawgrun/pkg/commands/db.go`:
- Line 70: Reset the remaining flag state variables alongside driverOverride
before flag parsing: ensure defaultGraphName and initGraphOnFail are explicitly
reset (e.g., set to "" and false respectively) in the same initialization block
where driverOverride is set so flag parsing starts from a known, consistent
state; update the same function that currently sets driverOverride (and
document/align with ClearFlagsFn if present) to include these resets referencing
the variables defaultGraphName and initGraphOnFail.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2b5e4c9b-fa90-4550-89de-750125f649b1
📒 Files selected for processing (1)
tools/dawgrun/pkg/commands/db.go
seanjSO
force-pushed
the
seanj/dawgrun-graph-schema
branch
from
a377ebb to
c472f37
Compare
2 participants
Description
Update dawgrun connection creation to select or create a default (or, named) graph when opening connection
Resolves: <TICKET_OR_ISSUE_NUMBER>
Type of Change
Testing
make test_allwithCONNECTION_STRINGset)Screenshots (if appropriate):
Driver Impact
drivers/pg)drivers/neo4j)Checklist
go.mod/go.sumare up to date if dependencies changedSummary by CodeRabbit
--default-graphflag to specify the default graph name for database connections (defaults to "default")--init-graphflag to enable automatic schema initialization when the default graph setup fails