Skip to content

bumping SHC version#209

Merged
emmanuelrobles merged 3 commits into2.Xfrom
chore/bump-version-SHC-4.6.1-rc
Apr 6, 2026
Merged

bumping SHC version#209
emmanuelrobles merged 3 commits into2.Xfrom
chore/bump-version-SHC-4.6.1-rc

Conversation

@emmanuelrobles
Copy link
Copy Markdown
Contributor

@emmanuelrobles emmanuelrobles commented Apr 6, 2026

Description

Bumping SHC to rc

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Summary by CodeRabbit

  • Chores
    • Updated internal library dependency selection to prefer the release variant when configured, resulting in the app using the newer 4.6.1-dev release of shared libraries.
    • CI build configuration changed to request the release library source so published builds pick up the release variant by default.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Adds a CommonLibsReleaseVersion property and updates _CommonLibsVersion selection to use CommonLibsReleaseVersion when CommonSource (case-insensitive) equals release. CI workflow updated to pass -p:CommonLibSource=Release to dotnet build.

Changes

Cohort / File(s) Summary
Project file — version selection
Sharphound.csproj
Added CommonLibsReleaseVersion = 4.6.1-dev.202604031715 and extended _CommonLibsVersion conditional to pick this value when $(CommonSource.ToLower()) == 'release'. Local vs non-local reference behavior unchanged.
CI workflow — build property
.github/workflows/publish.yml
Changed build invocation to pass -p:CommonLibSource=Release instead of Stable, aligning CI with the new release selection path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nibble on a version line,

release hops in, now all is fine,
CI whispers "Release" with cheer,
small changes make the path clear,
carrots, commits, and a tiny version sign 🥕

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks critical details in the 'Motivation and Context' section and is missing 'How Has This Been Tested?' section entirely. Add a 'Motivation and Context' section explaining why this version bump is necessary, and provide detailed testing information in the 'How Has This Been Tested?' section.
Title check ❓ Inconclusive The title 'bumping SHC version' is vague and lacks specificity about the version number or nature of the bump. Make the title more specific by including the target version, e.g., 'Bump SHC to 4.6.1-rc' or 'Update SHC version to release candidate'.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-version-SHC-4.6.1-rc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Sharphound.csproj`:
- Line 18: The regex extracting the patch from CommonLibsStableVersion
(`[0-9]+$`) is matching the trailing timestamp in the pre-release string and
producing an invalid _StablePatch/CommonLibsDevVersion; fix by either (a) making
CommonLibsStableVersion a true stable semantic version like "4.6.1" so the
existing regex yields the patch you expect, or (b) keep the dev build token and
instead set CommonSource to "stable" so _CommonLibsVersion uses the exact dev
version rather than synthesizing a malformed CommonLibsDevVersion; update the
project properties referring to CommonLibsStableVersion, _StablePatch,
CommonLibsDevVersion, CommonSource, and _CommonLibsVersion accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 701ae381-ab43-4de2-8636-545acf68e010

📥 Commits

Reviewing files that changed from the base of the PR and between b2cecec and e3f0c68.

📒 Files selected for processing (1)
  • Sharphound.csproj

@emmanuelrobles emmanuelrobles merged commit 50981c3 into 2.X Apr 6, 2026
2 of 3 checks passed
@emmanuelrobles emmanuelrobles deleted the chore/bump-version-SHC-4.6.1-rc branch April 6, 2026 20:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants