Conversation
fix: break out of localgroup/ura processing if we cant get a machine sid and log this appropriately
ddlees
approved these changes
Nov 3, 2022
sircodemane
approved these changes
Nov 3, 2022
superlinkx
approved these changes
Nov 3, 2022
Contributor
superlinkx
left a comment
superlinkx
left a comment
There was a problem hiding this comment.
Everything seems in order, pull
| "LDAP Exception in Loop: {0}. {1}. {2}. Filter: {3}. Domain: {4}.", | ||
| le.ErrorCode, le.ServerErrorMessage, le.Message, ldapFilter, domainName), le); | ||
| throw new LDAPQueryException( | ||
| $"LDAP Exception in Loop: {le.ErrorCode}. {le.ServerErrorMessage}. {le.Message}. Filter: {ldapFilter}. Domain: {domainName}.", le); |
Contributor
There was a problem hiding this comment.
I knew there had to be a better way to handle formatting these strings, I'll remember this for future interpolation needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some logical gaps in processing. Also does some filtering on group membership