Update LAPS schema#68
Merged
rvazarkar merged 2 commits intoSpecterOps:mainfrom Aug 16, 2023
spyr0-sec:update-laps-schema
Merged
Update LAPS schema#68rvazarkar merged 2 commits intoSpecterOps:mainfrom spyr0-sec:update-laps-schema
rvazarkar merged 2 commits intoSpecterOps:mainfrom
spyr0-sec:update-laps-schema
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
Adding this here for reference: https://learn.microsoft.com/en-us/windows-server/identity/laps/laps-technical-reference The new attribute checks out |
rvazarkar
approved these changes
Aug 16, 2023
Contributor
rvazarkar
left a comment
There was a problem hiding this comment.
Double checked for any references and this looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In April 2023, MS released their new iteration of LAPS which included a refactor of the LAPS attributes on Computer objects. Currently SharpHound looks for the
ms-acs-admpwdexpirationtimewhich is now know asmsLAPS-PasswordExpirationTime. Therefore this PR is to add that LDAP property and change HasLAPS() logic to return true if the computer object possesses either of this attributes.Motivation and Context
Testing CE in a lab with LAPS configured was not returning any objects with haslaps = True
How Has This Been Tested?
This has not been tested, however this is a (hopefully) simple change which will not break anything.
Types of changes
Checklist: