Prepare domain object attributes for ADCS ESC6#94
Merged
definitelynotagoblin merged 3 commits intoSpecterOps:v3from Jan 19, 2024
Merged
Prepare domain object attributes for ADCS ESC6#94definitelynotagoblin merged 3 commits intoSpecterOps:v3from
definitelynotagoblin merged 3 commits intoSpecterOps:v3from
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
IsDC and DomainSID will need to be elevated to a new property on the Computer model as well |
urangel
approved these changes
Jan 11, 2024
Contributor
urangel
left a comment
urangel
left a comment
There was a problem hiding this comment.
Using HasFlag feels more intuitive to me so I appreciate the change. Thanks for updating the tests!
definitelynotagoblin
force-pushed
the
anemeth/adcs-esc6_1
branch
from
4651320 to
e5f03e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.