fix: have EnterpriseOrganization check if the organization is present in the lookup#21
Merged
Merged
Conversation
… in the lookup and set 'collected' to that value, added test cases
d3vzer0
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Enterprise stub and explicit Organization collection create a GH_Organization node with the same node_id.
The stub hardcoded collected=false, and since BloodHound merges same-id nodes with last-writer-wins (ingest order not guaranteed), it could overwrite an explicitly-collected org's collected=true. This fix derives collected from the lookup so both records agree, making the result order-independent.
Changes:
src/openhound_github/models/enterprise_organization.py: In as_node, replaced hardcoded collected=False with a lookup-derived value:collected = self._lookup.org_login_for_id(self.node_id) is not Nonetests/test_enterprise_organization.py(new): Added unit tests covering collected=true (org in lookup), collected=false (absent), and per-node_id resolution in a multi-org enterprise.Motivation and Context
Resolves: BED-8783
Tested with K-Nexus Github environment