YT-CPPGL-68: Implement missing vertex view getters#99
Merged
SpectraL519 merged 9 commits intohgl-masterfrom Apr 10, 2026
Merged
YT-CPPGL-68: Implement missing vertex view getters#99SpectraL519 merged 9 commits intohgl-masterfrom
SpectraL519 merged 9 commits intohgl-masterfrom
Conversation
Owner
SpectraL519
commented
Apr 10, 2026
- Extended the graph class with missing vertex collection getters:
- Descriptor getters: neighbors, predecessors, successors
- ID getters: neighbor_ids, predecessor_ids, successor_ids
- Fixed the incident_edges logic error:
- Previously the function always called out_edges, which is correct for undirected graphs but not for directed graphs
- Extended the internal implementation classes with specific incident edges getters
- Aligned the graph class methods to use the proper underlying implementation type's methods
- Changed the are_incident method names for vertex pairs and edge pairs to use the proper term (are_adjacent)
- Cleaned up the layout of methods in the graph class and the implementation classes
- Cleaned up the gl module tests
SpectraL519
commented
Apr 10, 2026
Owner
Author
SpectraL519
left a comment
There was a problem hiding this comment.
My eyes hurt and I don't have the energy to read all of this as there is a lot of moving things around without changing them but the diff is quite large because of this and so I will let AI do the review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.