Skip to content

YT-CPPGL-68: Implement missing vertex view getters#99

Merged
SpectraL519 merged 9 commits intohgl-masterfrom
vertex-getters
Apr 10, 2026
Merged

YT-CPPGL-68: Implement missing vertex view getters#99
SpectraL519 merged 9 commits intohgl-masterfrom
vertex-getters

Conversation

@SpectraL519
Copy link
Copy Markdown
Owner

  • Extended the graph class with missing vertex collection getters:
    • Descriptor getters: neighbors, predecessors, successors
    • ID getters: neighbor_ids, predecessor_ids, successor_ids
  • Fixed the incident_edges logic error:
    • Previously the function always called out_edges, which is correct for undirected graphs but not for directed graphs
    • Extended the internal implementation classes with specific incident edges getters
    • Aligned the graph class methods to use the proper underlying implementation type's methods
  • Changed the are_incident method names for vertex pairs and edge pairs to use the proper term (are_adjacent)
  • Cleaned up the layout of methods in the graph class and the implementation classes
  • Cleaned up the gl module tests

@SpectraL519 SpectraL519 changed the base branch from master to hgl-master April 10, 2026 21:08
Copy link
Copy Markdown
Owner Author

@SpectraL519 SpectraL519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My eyes hurt and I don't have the energy to read all of this as there is a lot of moving things around without changing them but the diff is quite large because of this and so I will let AI do the review

Copy link
Copy Markdown
Owner Author

@SpectraL519 SpectraL519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@SpectraL519 SpectraL519 merged commit 4ff0b14 into hgl-master Apr 10, 2026
5 checks passed
@SpectraL519 SpectraL519 deleted the vertex-getters branch April 10, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant