JSDK-257: Negative tests for null streams and channels #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenverM80
approved these changes
Sep 7, 2017
rpmoore
suggested changes
Sep 7, 2017
| try { | ||
| new GetObjectRequest("BucketName", "ObjectName", null); | ||
| fail(); | ||
| } catch (final NullPointerException e) { |
Contributor
There was a problem hiding this comment.
I'm confused. Which of these catch clauses is the expected one?
rpmoore
approved these changes
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All constructors with stream or channel inputs now have a negative test to verify preconditions are working as expected. This consists of all constructors for:
Note: each tests is catching two exceptions. The null pointer exception is thrown by the precondition in the constructor (expected), and the illegal argument exception is thrown in IntelliJ IDEA due to the Nonnull annotation.