This still needs testing but this is the sparse fix #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rpmoore I'm trying to think about how to test this still. |
rpmoore
reviewed
Apr 19, 2019
| } | ||
|
|
||
| try { | ||
| striped.get(key).lock(); |
Contributor
There was a problem hiding this comment.
Why not get the lock once instead of twice?
Contributor
Author
There was a problem hiding this comment.
This is fixed, we only call striped.get once now. See changes in 878c16a
rpmoore
approved these changes
Apr 23, 2019
scribe
added a commit
that referenced
this pull request
Apr 23, 2019
* This still needs testing but this is the sparse fix * using slices * removing extra get for slice
rpmoore
pushed a commit
that referenced
this pull request
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how to write a unit test for this issue, but after working a lot with Kyle I believe this is a fix.