Vogels fix #138
Closed
Vogels fix #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowleya
reviewed
Feb 9, 2026
| # bool hard code for extracting the weights or not | ||
| EXTRACT_WEIGHTS = False | ||
| GENERATE_PLOT = False | ||
| GENERATE_PLOT = True |
Member
There was a problem hiding this comment.
Is this going to be OK in the integration tests?
Member
Author
There was a problem hiding this comment.
YES in fact the tests need that.
when it finds matplotlib.pyplot in the script it mocks that out (python hack)
Then checks the mock is actually called.
- Does not check how or with what t is called
Comment on lines
-54
to
-59
| def test_examples_balanced_random_balanced_random(self): | ||
| self.check_script("examples/balanced_random/balanced_random.py") | ||
|
|
||
| def test_examples_balanced_random_split_balanced_random_split(self): | ||
| self.check_script("examples/balanced_random/split/balanced_random_split.py") | ||
|
|
Member
There was a problem hiding this comment.
Have these been removed on purpose?
Member
Author
There was a problem hiding this comment.
ABSOLUTELY!
- This change is done automatically by script_builder.py
- that is what intergation tests do
- Try running the test it fails as that code has been moved. (removed as duplicate)
- The moved code is tested elsewhere
Member
Author
|
This PR got commits meant for another pr will redo |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #136
fixes #71
Adds an example for
synapses_stdp_izhikevich_neuromodulation_vogels_2011_additive.aplx