Skip to content

Fix projection get before run #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rowleya merged 11 commits into from
Jul 31, 2019
Merged

Fix projection get before run #681

rowleya merged 11 commits into from
Jul 31, 2019

Conversation

@andrewgait
Copy link
Contributor

@andrewgait andrewgait commented Jul 17, 2019 •
edited
Loading

Fixes #613 - fills in connection data for projections/connectors that use the synapse expander.

@andrewgait andrewgait added the bug label Jul 17, 2019
@andrewgait andrewgait added this to the 5.0.0 milestone Jul 17, 2019
@andrewgait andrewgait requested a review from rowleya July 17, 2019 16:35
@andrewgait andrewgait mentioned this pull request Jul 17, 2019
Merged
@coveralls
Copy link

coveralls commented Jul 17, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 5399

  • 23 of 48 (47.92%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 51.324%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spynnaker/pyNN/models/neuron/abstract_population_vertex.py 3 4 75.0%
spynnaker/pyNN/models/neuron/synaptic_manager.py 4 6 66.67%
spynnaker/pyNN/models/utility_models/synapse_expander/synapse_expander.py 8 30 26.67%
Files with Coverage Reduction New Missed Lines %
spynnaker/pyNN/models/utility_models/synapse_expander/synapse_expander.py 1 20.83%
Totals Coverage Status
Change from base Build 5246: -0.09%
Covered Lines: 5195
Relevant Lines: 10122
💛 - Coveralls

@andrewgait
Copy link
Contributor Author

andrewgait commented Jul 22, 2019

Latest commit fixes the doc-build errors observed at #661

@rowleya rowleya merged commit 5ab5052 into master Jul 31, 2019
@rowleya rowleya deleted the fix_projection_get_before_run branch July 31, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rowleya rowleya Awaiting requested review from rowleya

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

projection.get before run fails for some conntors

4 participants

@andrewgait @coveralls @rowleya