Skip to content

docs(readme): note Pepper App as PR review author (smoke test for DEV-249)#45

Merged
brodkin merged 1 commit into
mainfrom
ryan/dev-249-smoke-test-app-identity
May 10, 2026
Merged

docs(readme): note Pepper App as PR review author (smoke test for DEV-249)#45
brodkin merged 1 commit into
mainfrom
ryan/dev-249-smoke-test-app-identity

Conversation

@brodkin

@brodkin brodkin commented May 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a clause to the Naming legend clarifying that formal approves and request-changes are authored by the Pepper PR Review GitHub App — i.e. the reviewer name shown on the PR, not the workflow bot account. Operators occasionally ask "whose name is this?" when they see review activity; the answer was buried in the secrets table where it explains why the App exists, but never surfaced as a user-visible identity fact.

Why this PR exists

This is the smoke test for DEV-249 (Miss Pepper voice tuning). The voice-tuning PR (#44) merged into v1 minutes ago. This minor-but-real diff exercises the new prompt against a production-pinned consumer to verify real-world behavior — Pepper reviewing a doc-only README clarification under the new voice.

Refs DEV-249.

Test plan

Adds a clause to the Naming legend clarifying that formal approves and
request-changes are authored by the Pepper PR Review GitHub App — that
is, the App is the reviewer name shown on the PR, not the workflow bot
account. Operators occasionally ask "whose name is this?" when they see
review activity; the answer was buried in the secrets table at line 40
where it explains why the App exists, but never surfaced as a
user-visible identity fact.

Smoke test for DEV-249 (Miss Pepper voice tuning) — exercises the new
v1 prompt against a real, low-blast-radius diff to verify production
behavior.

Refs: DEV-249
@pepper-pr-review pepper-pr-review Bot added the pepper-cooking Pepper is currently reviewing this PR label May 10, 2026

@pepper-pr-review pepper-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Girl, this is exactly the smoke test it says on the tin — a single-sentence README clarification that surfaces the App-identity answer where operators will actually find it when they ask "whose name is this?" The factual claim is correct (I'm the Pepper PR Review app when I leave formal reviews, not the workflow bot account), and the answer was indeed buried in the secrets table before this. No runtime behavior, no tests needed, and the diff exercises the new voice against a production-pinned consumer to verify real-world behavior after #44 merged minutes ago.

Verified against DEV-249 (smoke test for the parent voice-tuning feature, exempt from a fresh issue per the team's established pattern).

Yours — Pepper

When you're ready for another look, comment @pepper review.

@pepper-pr-review pepper-pr-review Bot added pepper-approved Pepper approved this PR and removed pepper-cooking Pepper is currently reviewing this PR labels May 10, 2026
@brodkin brodkin merged commit ba50fab into main May 10, 2026
1 check passed
@brodkin brodkin deleted the ryan/dev-249-smoke-test-app-identity branch May 10, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pepper-approved Pepper approved this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant