Current through resistor issue#56
Closed
marcin-golebiowski wants to merge 3 commits intoSpiceSharp:developmentfrom
Closed
Current through resistor issue#56marcin-golebiowski wants to merge 3 commits intoSpiceSharp:developmentfrom
marcin-golebiowski wants to merge 3 commits intoSpiceSharp:developmentfrom
Conversation
marcin-golebiowski
changed the title
Member
|
At the moment, this doesn't work by design. A resistor does not define a branch current, so the behavioral source cannot compute derivatives for it... |
Member
Author
|
Any plans to change that? I think that could be nice feature. |
Member
|
The thing is that I don't know how to go about this correctly. Maybe I could add a optional flag that you can override the 'fully correct' behavior. You will in a lot of cases still get agreeable results, however it is hard to predict what it does for more complex stuff. I will also take a look how they do it in ngSpice for example. |
svenboulanger
added a commit
that referenced
this pull request
Apr 24, 2021
Member
|
It should be possible with v3.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with I(Resistor) in expressions.
Please find the unit test.