-
Notifications
You must be signed in to change notification settings - Fork 230
BlackrockSortingExtractor - load only .nev files, ignore nsX #3843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4f1bb48
nev alone
luiztauffer 7bddaa5
get sampling rate from spike channels
luiztauffer e854f8e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d7b6fb8
try to fix error, give preference to estimate rate from signal channels
luiztauffer a53e1d8
Merge branch 'blackrock-nev' of https://github.com/luiztauffer/spikei…
luiztauffer 3f73085
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d0393ea
Merge branch 'main' into blackrock-nev
alejoe91 26595b7
overwrite method in extractor
luiztauffer 9dcec4e
Merge branch 'blackrock-nev' of https://github.com/luiztauffer/spikei…
luiztauffer 538b35f
Merge branch 'main' into blackrock-nev
luiztauffer b312c10
remove method, add nsx_to_load kwarg
luiztauffer a457b1e
docstring
luiztauffer 5ed885a
Merge branch 'main' into blackrock-nev
luiztauffer d8ea01b
Apply suggestions from code review
h-mayorquin 2eed362
Merge branch 'main' into blackrock-nev
h-mayorquin ae28c1b
Merge branch 'main' into blackrock-nev
h-mayorquin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the typing of this seems strange, can you double check @luiztauffer?
Sam is going to vacations so if he does not have time to check it before that I will merge this next Monday but just double check this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h-mayorquin this comes from here: https://github.com/NeuralEnsemble/python-neo/blob/c425a529958d582919607a0eb940154a4b5c4d7e/neo/rawio/blackrockrawio.py#L97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, makes sense.