Add sparsity_mask option in estimate_templates_with_accumulator() #4194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yger
reviewed
Nov 4, 2025
Collaborator
yger
left a comment
yger
left a comment
There was a problem hiding this comment.
Great, but there will then be a missing function to quickly create Templates from compressed dense_arrays obtained with a given sparsity_mask. Because currently, the Templates object can only be created from dense. Maybe adding a Templates.from_sparse() constructor ?
Member
Author
|
@yger you can already create a sparse template using the standard constructor |
Collaborator
|
Yes, my bad, this looks good to me! |
yger
approved these changes
Nov 10, 2025
alejoe91
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sparsity_mask option in estimate_templates_with_accumulator()