Skip to content

Remove lack of units in NeoBaseExtractors #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 30, 2022
Merged

Remove lack of units in NeoBaseExtractors #758

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7310275
remove the warnings
h-mayorquin Jun 30, 2022
336be20
Revert "remove the warnings"
h-mayorquin Jun 30, 2022
ac751c6
revert and change to warning
h-mayorquin Jun 30, 2022
87ff4a7
Merge branch 'master' into remove_units_warning
h-mayorquin Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions spikeinterface/extractors/neoextractors/neobaseextractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import warnings

import numpy as np
from spikeinterface.core import (BaseRecording, BaseSorting, BaseEvent,
BaseRecordingSegment, BaseSortingSegment, BaseEventSegment)
Expand Down Expand Up @@ -64,8 +66,9 @@ def __init__(self, stream_id=None, all_annotations=False, **neo_kwargs):
units = signal_channels['units']
if not np.all(np.isin(units, ['V', 'Volt', 'mV', 'uV'])):
# check that units are V, mV or uV
error = f'This extractor based on neo.{self.NeoRawIOClass} have strange units not in (V, mV, uV) {units}'
print(error)
message = f'This extractor based on neo.{self.NeoRawIOClass} have strange units not in (V, mV, uV) {units}'
warnings.warn(message)

additional_gain = np.ones(units.size, dtype='float')
additional_gain[units == 'V'] = 1e6
additional_gain[units == 'Volt'] = 1e6
Expand Down