Skip to content

🐛 fix invisible map legend#67

Merged
igotinfected merged 1 commit intomainfrom
fix/legend-invisible
Mar 24, 2026
Merged

🐛 fix invisible map legend#67
igotinfected merged 1 commit intomainfrom
fix/legend-invisible

Conversation

@igotinfected
Copy link
Copy Markdown
Member

@igotinfected igotinfected commented Mar 24, 2026

Legend was invisible, fixed.

Summary by CodeRabbit

  • Refactor
    • Simplified internal styling logic for legend controls by removing unnecessary CSS class conditions while maintaining collapsible functionality and existing visual states.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 40e08e93-c2e3-429f-b8e9-e164a3cad4b7

📥 Commits

Reviewing files that changed from the base of the PR and between ceee85c and 8303d65.

📒 Files selected for processing (2)
  • src/Spillgebees.Blazor.Map.Assets/src/controls/legendControl.test.ts
  • src/Spillgebees.Blazor.Map.Assets/src/controls/legendControl.ts
💤 Files with no reviewable changes (2)
  • src/Spillgebees.Blazor.Map.Assets/src/controls/legendControl.ts
  • src/Spillgebees.Blazor.Map.Assets/src/controls/legendControl.test.ts

📝 Walkthrough

Walkthrough

The pull request removes the sgb-map-ctrl-group CSS class from the legend control's container by eliminating the conditional logic in the _buildContainerClassName() method. The corresponding test assertion that verified this class's presence has also been removed, while all other CSS classes remain intact.

Changes

Cohort / File(s) Summary
Legend Control
src/Spillgebees.Blazor.Map.Assets/src/controls/legendControl.ts, src/Spillgebees.Blazor.Map.Assets/src/controls/legendControl.test.ts
Removed the conditional sgb-map-ctrl-group CSS class from the legend container and its test assertion. Other CSS classes (maplibregl-ctrl, sgb-map-legend, collapsible states) remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A class removed, so clean and neat,
The legend dances with lighter feet,
No ctrl-group to weigh it down,
Just pure styles in this tiny town! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'fix invisible map legend' directly addresses the main change: removing the CSS class that was causing the legend to be invisible.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/legend-invisible

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@igotinfected igotinfected merged commit 19b03dc into main Mar 24, 2026
3 checks passed
@igotinfected igotinfected deleted the fix/legend-invisible branch March 24, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant