Skip to content

Conversation

@alexander-yevsyukov
Copy link
Contributor

This PR updates dependencies on Protobuf, Base, Validation, and other local and external dependencies via applying latest config.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +80 to 84
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<version>null</version>
<scope>test</scope>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace null JUnit versions or import BOM properly

The generated pom.xml now declares junit-jupiter-* dependencies with <version>null</version>, but there is no <dependencyManagement> BOM import to supply those versions. Maven will treat the literal string null as the version and fail to resolve these artifacts for any consumers of the published POM. If you intend to use junit-bom, it must be imported under <dependencyManagement> with <type>pom</type> and <scope>import</scope>, or the individual JUnit dependencies need explicit versions.

Useful? React with 👍 / 👎.

@alexander-yevsyukov alexander-yevsyukov added this pull request to the merge queue Dec 22, 2025
Merged via the queue into master with commit c60c1d6 Dec 22, 2025
6 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the update-validation-and-all branch December 26, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants