Prohibit automatic commits#661
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddd88f7b41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Shape 1: literal. | ||
| v=$(printf '%s' "$content" \ | ||
| | grep -E 'val[[:space:]]+versionToPublish[^=]*by[[:space:]]+extra\("' \ | ||
| | grep -E "val[[:space:]]+${name}([[:space:]]*:[[:space:]]*String)?[[:space:]]+by[[:space:]]+extra\(\"" \ |
There was a problem hiding this comment.
The new parse_version() regex now only matches declarations shaped like val <key>: String by extra(...), so it fails on valid forms such as val versionToPublish: String? by extra("...") (and other typed variants previously accepted). In those repos the script exits with code 2 (cannot parse ...), and publish-version-gate.sh treats that as a configuration error and allows ./gradlew to proceed, effectively disabling the version-bump protection on feature branches. This is a regression from the prior [^=]* matching and can silently permit publishes without a required bump.
Useful? React with 👍 / 👎.
2 participants
This PR improves setup of the agentic work so that agents do not commit to Git at will.
Other notable changes
update-copyright.shscript was improved to take into account variety of names of version properties declared inversion.gradle.ktsfiles across Spine SDK subprojects.