Type-specific entity states #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Improve common test fixtures.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the entity state implementation to support different entity kinds (Aggregate, ProcessManager, Projection, and generic Entity) by making entity states implement more specific interfaces based on their EntityOption.kind value. The version is bumped from 2.0.0-SNAPSHOT.027 to 2.0.0-SNAPSHOT.028.
Key changes:
- Enhanced
ImplementEntityStateto select the appropriate entity state interface based on entity kind - Added new test entities (
TransitionandBlob) to test different entity kinds - Refactored test utilities to use an extension property for generating Java file paths
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Bumped version to 2.0.0-SNAPSHOT.028 |
| pom.xml | Updated version reference to 2.0.0-SNAPSHOT.028 |
| entity/src/main/kotlin/io/spine/tools/core/jvm/entity/ImplementEntityState.kt | Enhanced to select entity state interface based on EntityOption kind |
| entity-tests/src/testFixtures/proto/given/entities/organization.proto | Added Transition and Blob test entities |
| entity-tests/src/test/kotlin/io/spine/tools/core/jvm/entity/ImplementEntityStateSpec.kt | New test file verifying correct interface selection |
| entity-tests/src/test/kotlin/io/spine/tools/core/jvm/entity/EntityPluginTestSetup.kt | Refactored to use extension property for Java file paths |
| entity-tests/src/test/kotlin/io/spine/tools/core/jvm/entity/query/*.kt | Updated to use refactored departmentJava property |
| entity-tests/src/test/kotlin/io/spine/tools/core/jvm/entity/field/AddFieldClassSpec.kt | Updated to use refactored departmentJava property |
| entity-tests/src/test/kotlin/io/spine/tools/core/jvm/entity/column/AddColumnClassSpec.kt | Updated to use refactored departmentJava property |
| dependencies.md | Auto-generated dependency report updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
entity/src/main/kotlin/io/spine/tools/core/jvm/entity/ImplementEntityState.kt
Outdated
Show resolved
Hide resolved
entity/src/main/kotlin/io/spine/tools/core/jvm/entity/ImplementEntityState.kt
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…o type-specific-entity-states
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
entity/src/main/kotlin/io/spine/tools/core/jvm/entity/ImplementEntityState.kt
Show resolved
Hide resolved
entity-tests/src/test/kotlin/io/spine/tools/core/jvm/entity/ImplementEntityStateSpec.kt
Outdated
Show resolved
Hide resolved
armiol
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the CoreJvm Compiler to use
ProcessManagerState,AggregateState, andProjectionStateinstead ofEntityStatewhen an entitykindset in the proto option is other thanENTITY. This is needed to allow specific generic type binding in corresponding entity classes in CoreJvm.